Force stroke='none' if 'stroke-width' === 0 (#271)

don't stroke text if stroke-width is zero Co-authored-by: Anna-Lena Lumpp <anna-lena.lumpp@yworks.com> Co-authored-by: Lukas Hollaender <lukas.hollaender@yworks.com>
yWorks · Aug 10, 2023 · c24a4e4 · c24a4e4
1 parent 07b8ca1
commit c24a4e4
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 3 deletions.
diff --git a/src/utils/text.ts b/src/utils/text.ts
@@ -9,11 +9,13 @@ type TextRenderingMode = typeof tol.renderingMode
 
 export function getTextRenderingMode(attributeState: AttributeState): TextRenderingMode {
   let renderingMode: TextRenderingMode = 'invisible'
-  if (attributeState.fill && attributeState.stroke) {
+  const doStroke = attributeState.stroke && attributeState.strokeWidth !== 0
+  const doFill = attributeState.fill
+  if (doFill && doStroke) {
     renderingMode = 'fillThenStroke'
-  } else if (attributeState.fill) {
+  } else if (doFill) {
     renderingMode = 'fill'
-  } else if (attributeState.stroke) {
+  } else if (doStroke) {
     renderingMode = 'stroke'
   }
   return renderingMode

diff --git a/test/common/tests.js b/test/common/tests.js
@@ -64,6 +64,7 @@ window.tests = [
   'vertical-align',
   'xml-space',
   'zero-width-strokes',
+  'zero-width-strokes-text',
   'current-color',
   'text-length'
 ]
diff --git a/test/specs/zero-width-strokes-text/reference.pdf b/test/specs/zero-width-strokes-text/reference.pdf
diff --git a/test/specs/zero-width-strokes-text/spec.svg b/test/specs/zero-width-strokes-text/spec.svg