Implement nested <tspan> support #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Uses recursive function to process nested `<tspan>`s - Improved text trimming support when `xml:space = "default"` - Tests also added
|
Tests were expected to fail, I haven't pushed updated reference PDFs in case you wanted to review yourself. All are due to a better text trimming/space consolidation implementation:
|
HackbrettXXX
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #123.
Implementation is how you'd expect: using a recursive function to process each
<tspan>in turn, the base case being when a child is simply a plain#textelement. The context of the parent element is passed down to each child.Note browsers seem to treat text chunks in a linear manner. That is to say that setting the
x/yattribute of a nested<tspan>will impact any subsequent<tspan>s, regardless of whether they're a child, sibling or at a higher level. This effectively means that the collection ofTextChunks can be stored as a 1D array, rather than a tree. See the third and fourth tests in the new spec SVG.Things are complicated by the correct trimming of text when
xml:space = "default". In particular, spaces need to be consolidated across elements in eachTextChunkand betweenTextChunks. Browsers also treatxml:spacedifferently:xml:spacecan be freely changed and all child elements inheritxml:spaceonce set topreservecannot be set back todefaultin any child elementThis PR uses the Chrome convention.