Style sheets #118
Merged
Style sheets #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…where a context object already exists
HackbrettXXX
requested changes
Nov 7, 2019
| @@ -0,0 +1,17 @@ | |||
| # Auto detect text files and perform LF normalization | |||
There was a problem hiding this comment.
Don't include the browser adapter in our repo. It is also available on npm:
https://www.npmjs.com/package/css-select-browser-adapter
src/svg2pdf.js
Outdated
| // returns an attribute of a node, either from the node directly or from css | ||
| var getAttribute = function (node, propertyNode, propertyCss) { | ||
| propertyCss = propertyCss || propertyNode; | ||
| var getAttribute = function (node, propertyNames, styleSheets) { |
There was a problem hiding this comment.
we could define getAttribute on the context object, as we need a context anyways for this.
There was a problem hiding this comment.
Actually I tried to implement it in a way that you can use getAttribute() without any context...
src/svg2pdf.js
Outdated
| } | ||
|
|
||
| StyleSheets.loadSheet = function (url) { | ||
| const request = new XMLHttpRequest(); |
There was a problem hiding this comment.
We could try and use the styleSheets API for this. Don't know if this works, though.
There was a problem hiding this comment.
I retried it and couldn't find any styleSheets in the debug.html DOM...
# Conflicts: # karma.conf.js # package-lock.json # package.json # src/applyparseattributes.ts # src/context/context.ts # src/nodes/circle.ts # src/nodes/clippath.ts # src/nodes/containernode.ts # src/nodes/ellipse.ts # src/nodes/geometrynode.ts # src/nodes/group.ts # src/nodes/image.ts # src/nodes/marker.ts # src/nodes/path.ts # src/nodes/pattern.ts # src/nodes/rect.ts # src/nodes/renderednode.ts # src/nodes/svg.ts # src/nodes/svgnode.ts # src/nodes/text.ts # src/nodes/use.ts # src/parse.ts # src/svg2pdf.ts # src/utils/bbox.ts # src/utils/misc.ts # src/utils/node.ts # src/utils/patterngradient.ts # src/utils/svgpathadapter.ts # src/utils/text.ts # test/common/tests.js # test/unit/webpack.config.js # tsconfig.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #81