Symbols #115
Merged
Symbols #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cf17c05.
…s + react to HackbrettXXX's comments
HackbrettXXX
requested changes
Oct 24, 2019
src/svg2pdf.js
Outdated
| @@ -279,6 +279,12 @@ SOFTWARE. | |||
| _pdf.beginFormObject(bBox[0], bBox[1], bBox[2], bBox[3], tfMatrix); | |||
| renderChildren(node, _pdf.unitMatrix, this, false, false, AttributeState.default()); | |||
| _pdf.endFormObject(node.getAttribute("id")); | |||
| } else if (nodeIs(node, "symbol,svg")) { | |||
| // create unclipped and untransformed form object | |||
| var bBox = getUntransformedBBox(node); | |||
There was a problem hiding this comment.
we should probably use a larger bBox here. At least in the svg case, this is the box determined by width/height or the viewBox.
src/svg2pdf.js
Outdated
| @@ -846,7 +871,7 @@ SOFTWARE. | |||
| ]; | |||
| } | |||
|
|
|||
| if (!nodeIs(node, "marker,svg,g")) { | |||
| if (!nodeIs(node, "marker,svg,g")) { // TODO: and !symbol ??? | |||
src/svg2pdf.js
Outdated
| @@ -863,6 +888,20 @@ SOFTWARE. | |||
| return boundingBox; | |||
| }; | |||
|
|
|||
| var getBoundingBoxByChildren = function (node) { | |||
| boundingBox = [0, 0, 0, 0]; | |||
tests/symbols/spec.svg
Outdated
| @@ -0,0 +1,16 @@ | |||
| <svg id="svgElement" width="500" height="500" xmlns="http://www.w3.org/2000/svg"> | |||
There was a problem hiding this comment.
We should probably add more cases:
- different transforms (on the
symbol, on theuse, "around" theuse, ...) - style inheritance from "around" the
useelement
tests/symbols/spec.svg
Outdated
| @@ -0,0 +1,16 @@ | |||
| <svg id="svgElement" width="500" height="500" xmlns="http://www.w3.org/2000/svg"> | |||
| <symbol id="myDot" x="1" height="100" viewBox="0 0 80 100" > | |||
There was a problem hiding this comment.
1px is really hard to see, make it e.g. 10px to really see an effect.
tests/symbols/spec.svg
Outdated
| <circle cx="50" cy="50" r="50"/> | ||
| </symbol> | ||
|
|
||
| <use href="#myDot" /> |
There was a problem hiding this comment.
maybe you could align the circles a little better and make them distinguishable, so it's immediately clear which circle is which.
…entation attribute), styling
This reverts commit 29eb4ea.
# Conflicts: # src/applyparseattributes.ts # src/context/referenceshandler.ts # src/nodes/geometrynode.ts # src/nodes/image.ts # src/nodes/renderednode.ts # src/nodes/svgnode.ts # src/nodes/text.ts # src/nodes/use.ts # src/utils/bbox.ts # src/utils/node.ts # test/common/tests.js # test/specs/complete-computer-network/reference.pdf # test/specs/image-svg-urls/reference.pdf # test/specs/references/reference.pdf
- don't add line width to bounding boxes, - refactor referenced handler (externalize rendering of referenced elements) - fix <use> viewBox transformations - hotfix pattern x/y offset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement symbols an update -handling; closes #110